feat(autocomplete): support variable option height #20324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 17, 2020
Historically `mat-select` and `mat-autocomplete` have behaved very similarly, because they were written around the same time and they share some logic by depending on `mat-option`. `mat-select` has to know all the option heights ahead of time so that it can position its panel correctly over the trigger. The limitation made its way into `mat-autocomplete`, even though there's no reason for it to be there. While implementing the MDC-based autocomplete, I refactored some code that makes it easier to support variable-height options so there changes enable the functionality for the non-MDC autocomplete too. DEPRECATED: * `AUTOCOMPLETE_OPTION_HEIGHT` is deprecated, because it isn't being used anymore. * `AUTOCOMPLETE_PANEL_HEIGHT` is deprecated, because it isn't being used anymore. Fixes angular#18030.
crisbeto
force-pushed
the
18030/autocomplete-option-height
branch
from
8c57673
to
f59a78a
Compare
|
Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically
mat-selectandmat-autocompletehave behaved very similarly, because they were written around the same time and they share some logic by depending onmat-option.mat-selecthas to know all the option heights ahead of time so that it can position its panel correctly over the trigger. The limitation made its way intomat-autocomplete, even though there's no reason for it to be there.While implementing the MDC-based autocomplete, I refactored some code that makes it easier to support variable-height options so these changes enable the functionality for the non-MDC autocomplete too.
DEPRECATED:
AUTOCOMPLETE_OPTION_HEIGHTis deprecated, because it isn't being used anymore.AUTOCOMPLETE_PANEL_HEIGHTis deprecated, because it isn't being used anymore.Fixes #18030.