feat(material/autocomplete) settable height of option; settable height of panel

[DmitryAstafyev]

feat(material/autocomplete) settable height of option; settable height of panel

Allows defining a height of option and a height of panel by setting optionHieght or/and panelHeight inputs on mat-autocomplete component.

Fixes: #18030
Related to: #3810, #10038

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[DmitryAstafyev]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[andreialecu]

There are so many github and stackoverflow issues related to this. Please get it merged. :)

[DmitryAstafyev]

There are so many github and stackoverflow issues related to this. Please get it merged. :)

Fixed api_golden_checks, all checks looks good, hope the process will go forward.

[xigolle]

Is there any update on this PR/Feature it sounds like it is a pretty requested future and I am personally also waiting for this.

[DmitryAstafyev]

pull request was created in 2019. All checks were good. A couple of times I've updated a pull-request to fit last updates of master. But it looks like nobody interests; even the community asks for such changes.

Well, I also don't have time to resolve every few weeks of new conflicts, without any kind of feedback from developers.

Sorry.

[Totati]

Wouldn't it be better if we could provide the heights with InjectionToken too? 😇 We need this feature too in many places.

[DmitryAstafyev]

@Totati All conflicts are resolved.
@crisbeto, @devversion, @jelbourn, @alexeagle what do you think? Is there any chance to be merged?

[jelbourn]

We're not sure that this is something we can support once the autocomplete is based on MDC-web, so any progress on this feature is blocked until that's further along.

[DmitryAstafyev]

MDC-web

@jelbourn Thanks for the reply first of all. Why MDC should block this feature? As default autocomplete component will fit MDC completely. But optionally, optionally, it would be great to have a way to change the height of items inside. Really, there are so many cases where >40px of height is too much.

[jelbourn]

It's just of making sure it integrates well into the system. The biggest part is ensuring that it fits with density API we're adding in https://github.com/angular/components/tree/density-api (which is on top of MDC's density API). Ideally I want to avoid adding run-time APIs (which increase the JS size) for theming-related concerns, which includes density.

[DmitryAstafyev]

@jelbourn can I help somehow? I don't know, maybe change code somehow?
About the amount of code:

856 lines added in total, but:
- 135 lines is a feature code
- rest lines: tests specification and MD 

So, there is not so much JS stuff.

In any way, can I do something to help you and angular team with it?

[jelbourn]

Probably not until we make more progress with the MDC-based version of MatAutocomplete

[crisbeto]

Once #20324 goes in you'll be able to control the option height through CSS so these changes shouldn't be necessary.

[andrewseguin]

Closing since the change should be fixed with #20324

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}