Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/list): return selected options from selection list selectAll/deselectAll #21358

Merged

Conversation

crisbeto
Copy link
Member

Returns an array of the changed options from the list's selectAll and deselectAll. This is information we have already so exposing it is trivial and makes some use cases slightly easier.

Fixes #21356.

…ctAll/deselectAll

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Dec 15, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 15, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw merged commit ae6e930 into angular:master Feb 5, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…ctAll/deselectAll (angular#21358)

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…ctAll/deselectAll (angular#21358)

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(selection-list): selectAll/deselectAll should return changedOptions
3 participants