Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(selection-list): selectAll/deselectAll should return changedOptions #21356

Closed
Totati opened this issue Dec 15, 2020 · 1 comment · Fixed by #21358, cayacdev/cashbox#88, ToWipf/jasmarty#155 or CarlosPavajeau/Kaizen#251
Closed

feat(selection-list): selectAll/deselectAll should return changedOptions #21356

Totati opened this issue Dec 15, 2020 · 1 comment · Fixed by #21358, cayacdev/cashbox#88, ToWipf/jasmarty#155 or CarlosPavajeau/Kaizen#251
Assignees
@crisbeto
Labels
area: material/list feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@Totati
Copy link
Contributor

Totati commented Dec 15, 2020

Feature Description

Calling selectAll or deselectAll on MatSelectionList should return the changedOptions array.

components/src/material/list/selection-list.ts

Line 521 in 3c37e4b

selectAll() {

components/src/material/list/selection-list.ts

Line 526 in 3c37e4b

deselectAll() {

Use Case

Previously #15696 has been fixed to work well with ctrl + A, and this made my work easier, however when i programatycally selectAll/deselectAll, I still need some custom logic to determine change. However you already have this list, so you could return it.

components/src/material/list/selection-list.ts

Line 678 in 3c37e4b

const changedOptions: MatListOption[] = [];

@Totati Totati added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Dec 15, 2020
@crisbeto crisbeto self-assigned this Dec 15, 2020
@crisbeto crisbeto added area: material/list has pr P4 A relatively minor issue that is not relevant to core functions and removed needs triage This issue needs to be triaged by the team labels Dec 15, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 15, 2020
@crisbeto
feat(material/list): return selected options from selection list sele…
8499dfe 
…ctAll/deselectAll

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
@crisbeto crisbeto mentioned this issue Dec 15, 2020
Merged
annieyw pushed a commit that referenced this issue Feb 5, 2021
@crisbeto
feat(material/list): return selected options from selection list sele…
ae6e930 
…ctAll/deselectAll (#21358)

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes #21356.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
feat(material/list): return selected options from selection list sele…
0517395 
…ctAll/deselectAll (angular#21358)

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
feat(material/list): return selected options from selection list sele…
c48fbea 
…ctAll/deselectAll (angular#21358)

Returns an array of the changed options from the list's `selectAll` and `deselectAll`.
This is information we have already so exposing it is trivial and makes some use
cases slightly easier.

Fixes angular#21356.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/list feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @Totati