-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(multiple): enable noImplicitOverride
typescript option
#22830
refactor(multiple): enable noImplicitOverride
typescript option
#22830
Conversation
Blocked on Google3 updating to TS 4.3 |
Enables the TypeScript `noImplicitOverride` option and adds the `override` keyword where needed.
Adds a `yarn run` alias for the `tsc` binary. Since we have multiple versions of TypeScript installed, Yarn can pick another version (e.g. from `typescript-4.2`) for linking the `tsc` binary. This is unexpected because `yarn tsc` should resolve to the TypeScript version that is not installed through a Yarn alias. Changing the order in the Yarn lock file does not help, and it seems expected in the context of Yarn which does not know which package (regardless of alias or not) to prefer.
a412675
to
b5e8231
Compare
noImplicitOverride
typescript optionnoImplicitOverride
typescript option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh nice, didn't know this was a thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh thats neat - thanks for making this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…gular#22830) * refactor(multiple): enable `noImplicitOverride` typescript option Enables the TypeScript `noImplicitOverride` option and adds the `override` keyword where needed. * build: add yarn script alias for tsc Adds a `yarn run` alias for the `tsc` binary. Since we have multiple versions of TypeScript installed, Yarn can pick another version (e.g. from `typescript-4.2`) for linking the `tsc` binary. This is unexpected because `yarn tsc` should resolve to the TypeScript version that is not installed through a Yarn alias. Changing the order in the Yarn lock file does not help, and it seems expected in the context of Yarn which does not know which package (regardless of alias or not) to prefer.
…2830) * refactor(multiple): enable `noImplicitOverride` typescript option Enables the TypeScript `noImplicitOverride` option and adds the `override` keyword where needed. * build: add yarn script alias for tsc Adds a `yarn run` alias for the `tsc` binary. Since we have multiple versions of TypeScript installed, Yarn can pick another version (e.g. from `typescript-4.2`) for linking the `tsc` binary. This is unexpected because `yarn tsc` should resolve to the TypeScript version that is not installed through a Yarn alias. Changing the order in the Yarn lock file does not help, and it seems expected in the context of Yarn which does not know which package (regardless of alias or not) to prefer.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Enables the TypeScript
noImplicitOverride
option and addsthe
override
keyword where needed.