Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): disable tab label color transition when animations are disabled #25308

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

crisbeto
Copy link
Member

Fixes that the transition of the tab label color wasn't being disabled when all animations are disabled.

…s are disabled

Fixes that the transition of the tab label color wasn't being disabled when all animations are disabled.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Jul 20, 2022
@crisbeto crisbeto requested a review from devversion July 20, 2022 07:56
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 20, 2022
@crisbeto crisbeto self-assigned this Jul 20, 2022
@crisbeto crisbeto merged commit 3a8f001 into angular:main Jul 20, 2022
crisbeto added a commit that referenced this pull request Jul 20, 2022
…s are disabled (#25308)

Fixes that the transition of the tab label color wasn't being disabled when all animations are disabled.

(cherry picked from commit 3a8f001)
crisbeto added a commit that referenced this pull request Jul 20, 2022
…s are disabled (#25308)

Fixes that the transition of the tab label color wasn't being disabled when all animations are disabled.

(cherry picked from commit 3a8f001)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 24, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.5/14.0.6) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.5/14.0.6) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.0.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1406-chromium-pinball-2022-07-20)

[Compare Source](angular/components@14.0.5...14.0.6)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [cc510216a](angular/components@cc51021) | fix | **autocomplete:** prevent outside clicks from going to other overlays ([#&#8203;25243](angular/components#25243)) |
| [b73b2fb85](angular/components@b73b2fb) | fix | **checkbox:** incorrect animation state when going from pre-checked to indeterminate ([#&#8203;25297](angular/components#25297)) |
| [e7b359286](angular/components@e7b3592) | fix | **slider:** add cancelable checks to touchmove and touchend events ([#&#8203;25301](angular/components#25301)) |
| [d7e422668](angular/components@d7e4226) | fix | **tabs:** disable tab label color transition when animations are disabled ([#&#8203;25308](angular/components#25308)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [43bfbac51](angular/components@43bfbac) | fix | **mdc-slider:** thumb incorrectly positioned when inside an overlay ([#&#8203;25288](angular/components#25288)) |

#### Special Thanks

Alka Vats, John Vandenberg, Kristiyan Kostadinov and Oliver Kierepka

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjMyLjExOS4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1469
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants