fix(material/list): fix tabindex="-1" not being maintained when disabled #25860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
crisbeto
reviewed
Oct 25, 2022
zarend
force-pushed
the
disabled-mdc-list
branch
from
d04e986
to
b809324
Compare
When entire list is disabled, avoid adding list options to the tab order in the following situations: - focusin event is triggered on an option. This can happen when the end user clicks on a list option. - ngOnInit happens when list is disabled - updating selection state When list is disabled tabindex of every option should always be -1. Tabindex was set to 0 mainly because `_resetActionOption` only considered when list options where disabled, but didn't consider when the list itself is disabled. Fix issues by setting tabindex to -1 when disabled and making `_handleFocusin` a noop when disabled.
zarend
force-pushed
the
disabled-mdc-list
branch
from
b809324
to
9e09a89
Compare
zarend
added a commit
that referenced
this pull request
Oct 28, 2022
…led (#25860) When entire list is disabled, avoid adding list options to the tab order in the following situations: - focusin event is triggered on an option. This can happen when the end user clicks on a list option. - ngOnInit happens when list is disabled - updating selection state When list is disabled tabindex of every option should always be -1. Tabindex was set to 0 mainly because `_resetActionOption` only considered when list options where disabled, but didn't consider when the list itself is disabled. Fix issues by setting tabindex to -1 when disabled and making `_handleFocusin` a noop when disabled. (cherry picked from commit 8304a94)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entire list is disabled, avoid adding list options to the tab order in the following situations:
When list is disabled tabindex of every option should always be -1. Tabindex was set to 0 mainly because
_resetActionOptiononly considered when list options where disabled, but didn't consider when the list itself is disabled.Fix issues by setting tabindex to -1 when disabled and making
_handleFocusina noop when disabled.