fix(material/dialog): dialog name on mac only using aria-label #29264
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
the
dev-app preview
|
Deployed dev-app for 4d12a2a to: https://ng-dev-previews-comp--pr-angular-components-29264-dev-rjpcttjr.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
dialog-name-title-fix
branch
3 times, most recently
from
eafae8b
to
85ba74d
Compare
Fixes bug with Angular Components Dialog component on Mac whether using Chrome or Firefox the screenreader does not read the dialog name/title unless it is using an aria-label. Updates the dialog-content-directives to read/apply the aria- labelledby and aria-describedby values if they exist. Fixes b/274674581
Fixes issue with Angular Components Dialog component where VoiceOver does not read the dialog name if the dialog is supposed to be read by aria-labelledby or aria-describedby attributes. Updates dialog-container.ts so that the aria-labelledby or aria-described by value (if any) is used as an aria-label value. Fixes b/274674581
Fixes Angular Components Dialog component where the dialog name is not read by VoiceOver/screenreader on macOS chrome & firefox browsers. Attempts to retrieve any id associated with aria-labelledby or aria-describedby and taking the innerHTML or the aria-label of that element and applying that value to the dialog's aria-label. Fixes b/274674581
essjay05
force-pushed
the
dialog-name-title-fix
branch
from
85ba74d
to
4d12a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug with Angular Components Dialog component on Mac whether using Chrome or Firefox the screenreader does not read the dialog name/title unless it is using an aria-label. Updates the dialog-content-directives to read/apply the aria- labelledby and aria-describedby values if they exist.
Fixes b/274674581