Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/dialog): dialog name on mac only using aria-label #29264

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix(material/dialog): dialog name on mac only using aria-label #29264

wants to merge 15 commits into from

Commits on Jul 30, 2024

  1. fix(material/dialog): dialog name on mac only using aria-label 

    Fixes bug with Angular Components Dialog component on Mac
whether using Chrome or Firefox the screenreader does not
read the dialog name/title unless it is using an aria-label.
Updates the dialog-content-directives to read/apply the aria-
labelledby and aria-describedby values if they exist.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    613ffb5 View commit details
    Browse the repository at this point in the history

  2. fix(material/dialog): macOS dialog title not read in chrome and firefox 

    Fixes issue with Angular Components Dialog component where VoiceOver
does not read the dialog name if the dialog is supposed to be read by
aria-labelledby or aria-describedby attributes. Updates dialog-container.ts
so that the aria-labelledby or aria-described by value (if any) is used
as an aria-label value.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    efed398 View commit details
    Browse the repository at this point in the history

  3. fix(material/dialog): dialog name not read on macOS chrome & firefox 

    Fixes Angular Components Dialog component where the dialog name is
not read by VoiceOver/screenreader on macOS chrome & firefox
browsers. Attempts to retrieve any id associated with aria-labelledby
or aria-describedby and taking the innerHTML or the aria-label of that
element and applying that value to the dialog's aria-label.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    adf6587 View commit details
    Browse the repository at this point in the history

  4. fix(material/dialog): dialog name not read by screenreader on mac chr… 

    …ome or firefox

Fixes bug in Angular Components Dialog component where the aria-labelledby
and aria-describedby values are not being read by Chrome or Firefox when
using a mac. This checks if there is an html attribute of aria-labelledby
or aria-describedby and grabs the innerText or aria-label value and uses
that value as the aria-label for the dialog only on mac using chrome or
firefox.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ed78aff View commit details
    Browse the repository at this point in the history

  5. fix(material/dialog): dialog name not read by mac screenreader on chr… 

    …ome and firefox

Fixes Angular Components Dialog component where the mac screenreader is not
reading the associated aria-labelledby id value as the dialog name/title.
Fixes logic checking for macos so that the function_getDialogName() gets
called when the value of the arialabelledby id element gets inserted into
the aria-label value.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5c5e362 View commit details
    Browse the repository at this point in the history

  6. fix(material/dialog): dialog name not read by sr on mac chrome & firefox 

    Cleans up fix for Angular Component Dialog component's fix to update
the dialog aria-label if the user's OS is a mac since mac using a
chrome or firefox browser the screenreader does NOT read the dialog
name if the value is portrayed by aria-labelledby or aria-describedby.
Cleaned up console logs and unused attributes.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9394f17 View commit details
    Browse the repository at this point in the history

  7. refactor(material/dialog): dialog name not read by sr on mac with chr… 

    …ome or firefox

Cleans up unused variables and comments.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    629c535 View commit details
    Browse the repository at this point in the history

  8. refactor(cdk/dialog): dialog name not read by sr for mac on chrome & … 

    …firefox

Removes test console logs from CDK dialog-container.ts.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6f63583 View commit details
    Browse the repository at this point in the history

  9. fix(material/dialog): dialog name not read by screenreader on macos u… 

    …sing chrome or firefox

Updates fix for Angular Components Dialog issue where the dialog name
is not being read by the screenreader when specifically using macos
(and potentially ios) screenreader when using chrome or firefox
browsers. Removes unused commented out code and includes ios as part
of the logic to call  _getDialogName().

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9ddba9c View commit details
    Browse the repository at this point in the history

  10. fix(material/dialog): dialog name not read by screenreader on mac chr… 

    …ome or firefox

Adds console.log tests to check new additions to Platform CDK
which will be used for dialog name fix instead of previous logic.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1b8ba9c View commit details
    Browse the repository at this point in the history

  11. fix(material/dialog): dialog name not read by sr on mac chrome or fir… 

    …efox

Updates previous fix adding Windows and Linux checks to Platform CDK
and replaces windows.navigator.userAgent with using Platform CDK
check.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b1e6950 View commit details
    Browse the repository at this point in the history

  12. fix(material/dialog): make reviewer suggested changes 

    Updates fix for Angular Components Dialog component to revert
previous changes to aria-describedBy value to what it previously
was to not upgrade its value to aria-label. Fixes _getDialogName
function to return a string which gets applied to the ariaLabel
config value.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b19aa71 View commit details
    Browse the repository at this point in the history

  13. refactor(material/dialog): make suggested PR changes 

    Updates previous fix to Angular Components Dialog component
to remove unnecessary to our fix platform checks for WINDOWS
and LINUX. Simplifies logic to check for platform in material/
dialog-container.

Fixes b/274674581
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    89e1de1 View commit details
    Browse the repository at this point in the history

  14. refactor(material/dialog): fix lint errors 

    Updates previous fix and removes unused import to fix lint error.
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0535924 View commit details
    Browse the repository at this point in the history

  15. refactor(material/dialog): updates prioritization order of aria-label… 

    … adoption

Updates to put aria-labelledby values as the priority and the aria-label as
the backup.
    @essjay05
    essjay05 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dfc42ff View commit details
    Browse the repository at this point in the history