-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to this._getFlowDirection(this.parentElement, true); overwrites flex-direction set in stylesheet #364
Labels
Milestone
Comments
I believe this is a duplicate of #272. |
ThomasBurleson
added a commit
that referenced
this issue
Aug 7, 2017
fxFlex works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assiged (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element. When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value. Fixes #272, #364.
ThomasBurleson
added a commit
that referenced
this issue
Aug 7, 2017
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element. When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value. Fixes #272, #364.
ThomasBurleson
added a commit
that referenced
this issue
Aug 7, 2017
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element. When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value. > It is assumed that if the parent element has a `flex-direction` style property set, then the other required properties (display, border-box, etc.) have also been assigned. Fixes #272, #364.
mmalerba
pushed a commit
that referenced
this issue
Aug 7, 2017
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element. When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value. > It is assumed that if the parent element has a `flex-direction` style property set, then the other required properties (display, border-box, etc.) have also been assigned. Fixes #272, #364.
Fixed with SHA dde889d |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Commit #353 will set the flex-direction of the parent container to row when using fxFlex on a child element in this line. In our app, we set the flex-direction to column in a stylesheet, but the method only reads from the style attribute. Thus, the column flex-direction is overwritten.
This is where the child element sets the flex-direction of the parent element.
https://github.com/angular/flex-layout/blob/master/src/lib/flexbox/api/flex.ts#L162
My workaround has been to do
The text was updated successfully, but these errors were encountered: