Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update rxjs operators and jasmine #523

Closed
wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Dec 4, 2017

Incorporates PR #474 and updates rxjs to latest best practices

Fixes #519, #508, #533

@CaerusKaru
Copy link
Member Author

CaerusKaru commented Dec 4, 2017

Passes all tests.

cc @ThomasBurleson

@fbascheper
Copy link

It would be great if you could update this PR for Angular 5.1 and cdk 5.0.0 (stable) which were released tonight.

@CaerusKaru
Copy link
Member Author

@fbascheper Added

* fix: import individual rx operators
* Removes 'rxjs/operators' import in favor of indivial imports,
  adds lint rule to prevent that type of import
* Maintains parity with angular/components#8160
@ThomasBurleson
Copy link
Contributor

Merged with SHA 62457a5.

Super... super helpful. Great work Adam!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer Dependency Error With FlexLayout On Angular5
4 participants