-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(license): add license component to display full license #598
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see a dedicated page for the license, but there's a couple of small nitpicks that should be fixed before it can be merged.
@@ -0,0 +1,21 @@ | |||
<div class="license-content"> | |||
<p class="license-title">The MIT License</p> | |||
<p>Copyright (c) 2010-2019 Google LLC. <a href="license">http://material.angular.io/license</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a good idea to use routerLink
here instead of a href
tag
@@ -4,6 +4,7 @@ import {MatButtonModule} from '@angular/material/button'; | |||
import {FooterModule} from '../../shared/footer/footer'; | |||
import {RouterModule} from '@angular/router'; | |||
import {ComponentPageTitle} from '../page-title/page-title'; | |||
import { LicenseModule } from '../license/license'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the spaces surrounding the import.
import { LicenseModule } from '../license/license'; | |
import {LicenseModule} from '../license/license'; |
@@ -0,0 +1,16 @@ | |||
import { Component, NgModule } from "@angular/core"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be indented with 2 spaces instead of 4 and use single quotes instead of double quotes as well as removing the spaces from your import statements.
@@ -0,0 +1,16 @@ | |||
@import '../../../styles/constants'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be indented with 2 spaces instead of 4.
@@ -1,5 +1,7 @@ | |||
import {Component, NgModule} from '@angular/core'; | |||
import {materialVersion} from '../version/version'; | |||
import { RouterModule } from '@angular/router'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the spaces surrounding the import.
import { RouterModule } from '@angular/router'; | |
import {RouterModule} from '@angular/router'; |
@@ -14,6 +16,7 @@ export class Footer { | |||
|
|||
|
|||
@NgModule({ | |||
imports: [RouterModule.forRoot(MATERIAL_DOCS_ROUTES)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use RouterModule#forChild
instead of RouterModule#forRoot
on submodules/lazy-loaded modules (as indicated in the API docs for RouterModule
).
imports: [RouterModule.forRoot(MATERIAL_DOCS_ROUTES)], | |
imports: [RouterModule.forChild(MATERIAL_DOCS_ROUTES)], |
@@ -1,5 +1,7 @@ | |||
import {Component, NgModule} from '@angular/core'; | |||
import {materialVersion} from '../version/version'; | |||
import { RouterModule } from '@angular/router'; | |||
import { MATERIAL_DOCS_ROUTES } from '../../routes'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the spaces surrounding the import.
import { MATERIAL_DOCS_ROUTES } from '../../routes'; | |
import {MATERIAL_DOCS_ROUTES} from '../../routes'; |
Adding the full license aggreement as per angular.io example in reference to angular/components#16039