Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

chips: can't edit chips mobile devices #10532

Closed
matew17 opened this issue Mar 27, 2017 · 0 comments · Fixed by #11323
Closed

chips: can't edit chips mobile devices #10532

matew17 opened this issue Mar 27, 2017 · 0 comments · Fixed by #11323
Assignees
Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug ui: mobile
Milestone

Comments

@matew17
Copy link

matew17 commented Mar 27, 2017

I cannot edit md-chips on mobile devices

  • when I try to modify md-chips on mobile devices it doesn't work, I tried on iOS and android devices and both have the same behavior.
  • What is the expected behavior?: I should be able to edit the md-chips on mobile devices.

We don't need a code pen, you can go to: https://material.angularjs.org/latest/demo/chips
on a mobile device and try to do it, and it doesn't allow.

@Splaktar Splaktar changed the title I cannot edit md-chips on mobile devices chips: can't edit chips mobile devices Jun 11, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone Jun 11, 2018
@Splaktar Splaktar self-assigned this Jun 11, 2018
@Splaktar Splaktar added type: bug ui: mobile P3: important Important issues that really should be fixed when possible. labels Jun 11, 2018
Splaktar added a commit that referenced this issue Jun 11, 2018
use jQuery's `contents()` instead of `children()`
since the chip content elements are text nodes
and `children()` doesn't find text nodes
improve double click detection when editable chips are enabled
add/improve JSDoc and types
rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing`

Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
Splaktar added a commit that referenced this issue Jun 17, 2018
use jQuery's `contents()` instead of `children()`
since the chip content elements are text nodes
and `children()` doesn't find text nodes
improve double click detection when editable chips are enabled
add/improve JSDoc and types
rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing`

Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
@Splaktar Splaktar added the has: Pull Request A PR has been created to address this issue label Jun 19, 2018
jelbourn pushed a commit that referenced this issue Jun 22, 2018
use jQuery's `contents()` instead of `children()`
since the chip content elements are text nodes
and `children()` doesn't find text nodes
improve double click detection when editable chips are enabled
add/improve JSDoc and types
rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing`

Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
Splaktar added a commit that referenced this issue Jul 31, 2018
use jQuery's `contents()` instead of `children()`
since the chip content elements are text nodes
and `children()` doesn't find text nodes
improve double click detection when editable chips are enabled
add/improve JSDoc and types
rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing`

Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug ui: mobile
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants