This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(chips): editable chip gets removed after editing #11323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
a11y
googlebot
added
the
cla: yes
This was referenced Jun 11, 2018
use jQuery's `contents()` instead of `children()` since the chip content elements are text nodes and `children()` doesn't find text nodes improve double click detection when editable chips are enabled add/improve JSDoc and types rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing` Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
Splaktar
added a commit
that referenced
this pull request
Jul 9, 2018
- don't override defaults for scope variables which aren't defined - properly mark scope variables as optional in chips directive - the default inputAriaLabel, deleteHint, etc should not be rendered - deleteHint in chip content broke the ability to edit chips - move deleteHint out of chip content and only aria-label on md-chip - handle edge case in editing when the user clears the content and then enters new content Fixes #11322. Relates to #11323.
3 tasks
jelbourn
pushed a commit
that referenced
this pull request
Jul 11, 2018
- don't override defaults for scope variables which aren't defined - properly mark scope variables as optional in chips directive - the default inputAriaLabel, deleteHint, etc should not be rendered - deleteHint in chip content broke the ability to edit chips - move deleteHint out of chip content and only aria-label on md-chip - handle edge case in editing when the user clears the content and then enters new content Fixes #11322. Relates to #11323.
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
use jQuery's `contents()` instead of `children()` since the chip content elements are text nodes and `children()` doesn't find text nodes improve double click detection when editable chips are enabled add/improve JSDoc and types rename `MdChipCtrl.isEditting` to `MdChipCtrl.isEditing` Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
- don't override defaults for scope variables which aren't defined - properly mark scope variables as optional in chips directive - the default inputAriaLabel, deleteHint, etc should not be rendered - deleteHint in chip content broke the ability to edit chips - move deleteHint out of chip content and only aria-label on md-chip - handle edge case in editing when the user clears the content and then enters new content Fixes #11322. Relates to #11323.
Splaktar
added a commit
that referenced
this pull request
Aug 2, 2018
- don't override defaults for scope variables which aren't defined - properly mark scope variables as optional in chips directive - the default inputAriaLabel, deleteHint, etc should not be rendered - deleteHint in chip content broke the ability to edit chips - move deleteHint out of chip content and only aria-label on md-chip - handle edge case in editing when the user clears the content and then enters new content Fixes #11322. Relates to #11323.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Editing chips is completely broken.
Issue Number:
Fixes #11298. Fixes #10392. Fixes #10532. Fixes #10664. Fixes #10879.
What is the new behavior?
contents()instead ofchildren()since the chip content elements are text nodes andchildren()doesn't find text nodes.MdChipCtrl.isEdittingtoMdChipCtrl.isEditingDoes this PR introduce a breaking change?
Other information