Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

input(required): remove space before asterisks (required text indicator) #11418

Closed
fmax32 opened this issue Aug 17, 2018 · 3 comments
Closed
Assignees
Labels
P5: nice to have These issues will not be fixed without community contributions. type: spec alignment For issues related to aligning with the Material Design Spec

Comments

@fmax32
Copy link

fmax32 commented Aug 17, 2018

Bug, enhancement request, or proposal:

Based on Material Design guidelines, there should be no space after plceholder. Guidelines here: https://material.io/design/components/text-fields.html#anatomy

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

https://stackblitz.com/edit/angular-v6uj63

Detailed Reproduction Steps:

  1. for an input field (like email) set "required" attribute.
  2. open in browser to see that there is a space after "email" and before "*": "email *"

What is the expected behavior?

Expected to not have space between "email" and the asterisk "*", like this: "email*"

What is the current behavior?

There is a space after placeholder and before asterisk

What is the use-case or motivation for changing an existing behavior?

Following Material Design guidelines: https://material.io/design/components/text-fields.html#anatomy

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: any
  • AngularJS Material: 1.1.10
  • OS: any
  • Browsers: any

Is there anything else we should know? Stack Traces, Screenshots, etc.

N/A

codymikol pushed a commit to codymikol/material that referenced this issue Aug 17, 2018
remove the space between input labels and the asterisk that appears
when they are required

Fixes angular#11418
@codymikol
Copy link
Contributor

Just put in a PR for you 🐔

@Splaktar Splaktar changed the title For text-fields with required attribute, remove space before asterisks (required text indicator) input(required): remove space before asterisks (required text indicator) Aug 27, 2018
@Splaktar Splaktar added needs: team discussion This issue requires a decision from the team before moving forward. type: spec alignment For issues related to aligning with the Material Design Spec labels Aug 27, 2018
@Splaktar Splaktar self-assigned this Aug 27, 2018
@Splaktar
Copy link
Member

AngularJS Material currently follows the 2017 Material Design spec and not the spec that came out in 2018.

The 2018 spec has major changes and does not specify guidelines for the full set of components that AngularJS Material supports (datepickers, etc).

The team needs to discuss and come up with a more comprehensive strategy for how we are going to handle these kinds of issues (especially when the two spec's contradict each other).

@Splaktar Splaktar added this to the - Backlog milestone Aug 27, 2018
@Splaktar Splaktar added the P5: nice to have These issues will not be fixed without community contributions. label Aug 27, 2018
@Splaktar Splaktar removed the needs: team discussion This issue requires a decision from the team before moving forward. label Nov 3, 2018
@Splaktar Splaktar removed this from the - Backlog milestone Nov 3, 2018
@Splaktar
Copy link
Member

Splaktar commented Nov 3, 2018

The provided Stackblitz actually references Angular Material rather than AngularJS Material. We've discussed this and we'll be sticking to the 2014-2017 MD spec for AngularJS Material, so the current implementation with a space is correct.

This does appear to be an issue with Angular Material, as seen in this example, but that issue needs to be opened at https://github.com/angular/material2/issues.

@Splaktar Splaktar closed this as completed Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5: nice to have These issues will not be fixed without community contributions. type: spec alignment For issues related to aligning with the Material Design Spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants