Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

chore: upgrade to Karma 3.x and Jasmine 3.2.x #11489

Open
1 of 2 tasks
Splaktar opened this issue Oct 17, 2018 · 2 comments
Open
1 of 2 tasks

chore: upgrade to Karma 3.x and Jasmine 3.2.x #11489

Splaktar opened this issue Oct 17, 2018 · 2 comments
Assignees
@Splaktar
Labels
P3: important Important issues that really should be fixed when possible. type: chore
Milestone
- Backlog

Comments

@Splaktar
Copy link
Member

Splaktar commented Oct 17, 2018 •
edited

Bug, enhancement request, or proposal:

Proposal

Steps to reproduce the issue:

https://github.com/angular/material/blob/v1.1.10/package.json#L62-L71

What is the expected behavior?

We depend upon recent versions of Karma and Jasmine.

What is the current behavior?

Currently we depend on very old versions of Karma and Jasmine.

What is the use-case or motivation for changing an existing behavior?

This Karma version has some high security vulnerabilities. It also makes it harder to track down test failures or issues like #11487 when we're based on old versions of these testing libraries.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.x
  • AngularJS Material: 1.1.10
  • OS: all
  • Browsers: all

Is there anything else we should know? Stack Traces, Screenshots, etc.

  • Karma updated
  • Jasmine updated
@Splaktar Splaktar self-assigned this Oct 17, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Oct 17, 2018
@Splaktar Splaktar added type: chore P3: important Important issues that really should be fixed when possible. labels Oct 17, 2018
Splaktar added a commit that referenced this issue Oct 26, 2018
@Splaktar
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines
5059cc1 
- stop blocking shift-tab from moving focus away from the nav-bar
- enable the use of the home and end keys
- wrap to the first/last tab when hitting the end
- properly manage nav item tabindex values
- skip over disabled tabs instead of leaving focus in a bad state
- remove click listener on destroy
- update to latest karma version

Fixes #10419. Relates to #11489.
@Splaktar Splaktar mentioned this issue Oct 26, 2018
Merged
3 tasks
@Splaktar
Copy link
Member Author

PR #11494 updates Karma to the latest.

Updating Jasmine won't be so easy as there are a lot more breaking changes.

Splaktar added a commit that referenced this issue Oct 26, 2018
@Splaktar
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines
6752cce 
- stop blocking shift-tab from moving focus away from the nav-bar
- enable the use of the home and end keys
- wrap to the first/last tab when hitting the end
- properly manage nav item tabindex values
- skip over disabled tabs instead of leaving focus in a bad state
- remove click listener on destroy
- document keyboard behaviors
- fix bad linking syntax in API docs
- update to latest karma version

Fixes #10419. Relates to #11489.
Splaktar added a commit that referenced this issue Oct 26, 2018
@Splaktar
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines
d06e6f2 
- stop blocking shift-tab from moving focus away from the nav-bar
- enable the use of the home and end keys
- wrap to the first/last tab when hitting the end
- properly manage nav item tabindex values
- skip over disabled tabs instead of leaving focus in a bad state
- remove click listener on destroy
- document keyboard behaviors
- fix bad linking syntax in API docs
- update to latest karma version

Fixes #10419. Relates to #11489.
jelbourn pushed a commit that referenced this issue Nov 6, 2018
@Splaktar @jelbourn
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines (#11494)
4d29450 
- stop blocking shift-tab from moving focus away from the nav-bar
- enable the use of the home and end keys
- wrap to the first/last tab when hitting the end
- properly manage nav item tabindex values
- skip over disabled tabs instead of leaving focus in a bad state
- remove click listener on destroy
- document keyboard behaviors
- fix bad linking syntax in API docs
- update to latest karma version

Fixes #10419. Relates to #11489.
marosoft pushed a commit to marosoft/material that referenced this issue Nov 11, 2018
@Splaktar @marosoft
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines (angu…
fb6669b 
…lar#11494)

- stop blocking shift-tab from moving focus away from the nav-bar
- enable the use of the home and end keys
- wrap to the first/last tab when hitting the end
- properly manage nav item tabindex values
- skip over disabled tabs instead of leaving focus in a bad state
- remove click listener on destroy
- document keyboard behaviors
- fix bad linking syntax in API docs
- update to latest karma version

Fixes angular#10419. Relates to angular#11489.
@Splaktar Splaktar modified the milestones: 1.1.11, 1.1.12 Dec 14, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@Splaktar Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 10, 2019
@Splaktar Splaktar modified the milestones: 1.1.13, 1.1.14 Feb 10, 2019
This was referenced Feb 28, 2019
Merged
Merged
@Splaktar Splaktar modified the milestones: 1.1.14, 1.1.15 Mar 14, 2019
@Splaktar Splaktar modified the milestones: 1.1.15, 1.1.16, 1.1.18, 1.1.19 Mar 29, 2019
codymikol added a commit to codymikol/material that referenced this issue Apr 20, 2019
@codymikol
chore(tests):remove unused phantomJS workaround
21d9bf1 
this is no longer necessary as phantomJS is not used anymore

Relates to angular#11489
codymikol added a commit to codymikol/material that referenced this issue Apr 20, 2019
@codymikol
chore(tests): use beforeAll where possible
0a6d426 
setting up jasmine matchers and mockElementFocus don't need to be
evaluated every time a test runs.

Relates to angular#11489
mmalerba pushed a commit that referenced this issue Apr 24, 2019
@codymikol @mmalerba
chore(tests): use beforeAll where possible (#11658)
08bc72e 
setting up jasmine matchers and mockElementFocus don't need to be
evaluated every time a test runs.

Relates to #11489
mmalerba pushed a commit that referenced this issue Apr 24, 2019
@codymikol @mmalerba
chore(tests):remove unused phantomJS workaround (#11659)
84ac558 
this is no longer necessary as phantomJS is not used anymore

Relates to #11489
@Splaktar Splaktar mentioned this issue May 30, 2019
Merged
3 tasks
@Splaktar Splaktar modified the milestones: 1.1.19, 1.1.21, 1.1.20 May 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.20, 1.1.21 Aug 15, 2019
@Splaktar Splaktar modified the milestones: 1.1.21, 1.1.22 Sep 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.22, 1.1.23 Oct 22, 2019
@Splaktar Splaktar modified the milestones: 1.1.23, 1.2.1 May 6, 2020
@Splaktar Splaktar modified the milestones: 1.2.1, 1.2.2 Sep 14, 2020
@Splaktar Splaktar modified the milestones: 1.2.2, - Backlog Dec 16, 2020
@Splaktar
Copy link
Member Author

Splaktar commented Jun 3, 2021

Related PR #12103 updates to Karma v6.

@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
P3: important Important issues that really should be fixed when possible. type: chore
Projects
None yet
Milestone
- Backlog
Development

No branches or pull requests
1 participant
@Splaktar