Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

chore(tests): remove unused phantomJS workaround #11659

Merged
merged 1 commit into from Apr 24, 2019

Conversation

codymikol
Copy link
Contributor

this is no longer needed as phantomJS is not used

Fixes: N/A

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[x] Other... Please describe:

What is the current behavior?

There is a bit of functionality that was at one point useful for working around phantomJS not implementing click() on HTML elements, this is no longer required as phantomJS is not used.

Issue Number: N/A

What is the new behavior?

This workaround has been removed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This was a change that was made while investigating #11489 but was unrelated and a PR could be made separately.

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Feb 28, 2019
@Splaktar Splaktar self-assigned this Mar 16, 2019
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this.

Please update the commit message to use present (not past tense) as mentioned in our commit message guidelines. I.e. removed -> remove.

Please change the Fixes N/A line to Relates to #11489.

@Splaktar Splaktar added this to the 1.1.15 milestone Mar 16, 2019
@Splaktar Splaktar added type: chore P4: minor Minor issues. May not be fixed without community contributions. in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 16, 2019
@Splaktar Splaktar modified the milestones: 1.1.15, 1.1.16, 1.1.18, 1.1.19 Mar 29, 2019
this is no longer necessary as phantomJS is not used anymore

Relates to angular#11489
@codymikol codymikol force-pushed the jasmine-remove-phantomJS-hack branch from c368c27 to 21d9bf1 Compare April 20, 2019 17:52
@codymikol
Copy link
Contributor Author

I updated the commit message @Splaktar 🐔 sorry for the delay on all this!

Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: merge safe and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Apr 24, 2019
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Apr 24, 2019
@mmalerba mmalerba merged commit 84ac558 into angular:master Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants