Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): don't resize the container in updateSize() #11518

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Calling this.setSize_(size) results in the containers width/height being changed which is undesirable and causes tests to fail inside of g3.

Issue Number:
Relates to #11500

What is the new behavior?

Just set this.size and avoid resizing the container in updateSize().

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added type: bug severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Nov 16, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Nov 16, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 16, 2018
@andrewseguin andrewseguin merged commit c1c4523 into master Nov 16, 2018
@Splaktar Splaktar deleted the virtualRepeatUpdateSizeFix branch November 16, 2018 19:55
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants