Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): carrot not aligned to end in IE11 #11544

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Dec 15, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Carrots in md-selects are not aligned to the end in IE11 as explained in the issue.

Issue Number:
Fixes #10714. Relates to #3840.

What is the new behavior?

Carrots are properly positioned in IE11, Edge, Chrome, and Firefox.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thank you to @prestonvanloon for the original fix here in #3840.

@Splaktar Splaktar added type: bug ui: CSS browser: IE This issue is specific to Internet Explorer P2: required Issues that must be fixed. labels Dec 15, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Dec 15, 2018
@Splaktar Splaktar self-assigned this Dec 15, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 15, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Dec 15, 2018
@Splaktar Splaktar assigned jelbourn and mmalerba and unassigned jelbourn Dec 20, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@mmalerba mmalerba merged commit bf5bbfc into master Jan 7, 2019
@Splaktar Splaktar deleted the select-fixCarrotIE branch January 7, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select: icon is wrongly positioned in IE11
5 participants