Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(icon): symbol icons not working #11706

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix(icon): symbol icons not working #11706

merged 1 commit into from
Apr 12, 2019

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Apr 10, 2019 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • symbol icons aren't displayed

Issue Number:
Fixes #11705

What is the new behavior?

  • symbol icons display again
  • remove extra </path> in symbol-icons.svg
  • add symbol-icons.svg file for use in SVG Icon Set CodePens

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

  • Verify behavior on IE11 and Edge

@Splaktar
fix(icon): symbol icons not working on browsers other than IE11
1077df0 
remove extra </path> in symbol-icons.svg
add symbol-icons.svg file for use in Svg Icon Set CodePens

Fixes #11705
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 10, 2019
@Splaktar Splaktar self-assigned this Apr 10, 2019
@Splaktar Splaktar added this to the 1.1.19 milestone Apr 10, 2019
@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug labels Apr 10, 2019
@Splaktar Splaktar changed the title fix(icon): symbol icons not working on browsers other than IE11 fix(icon): symbol icons not working Apr 10, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Apr 10, 2019
@Splaktar Splaktar marked this pull request as ready for review April 10, 2019 08:00
@andrewseguin andrewseguin merged commit a62d160 into master Apr 12, 2019
@Splaktar Splaktar deleted the icon-fixSymbolIcons branch April 13, 2019 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Milestone
1.1.19
Development

Successfully merging this pull request may close these issues.

icon: symbol SVG icon set doesn't work since v1.1.11
3 participants
@Splaktar @googlebot @andrewseguin