Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

refactor(): change .md-padding to layout-padding #2221

Closed
wants to merge 1 commit into from

Conversation

marcysutton
Copy link
Contributor

This PR changes all <md-content class="md-padding"> instances in the docs to use [layout-padding] instead.

We discussed making md-content padded by default given the frequency of use in our docs, but I decided against it once I saw how many things it affected. md-content elements are frequently nested, so it undesirably stacked margins against each other.

One outstanding question I have is about the default margin/padding for md-content: currently [layout-padding] uses the baseline grid of 8px, but I see 16px used much more often. IMO, the framework should have one attribute that adjusts its size in SCSS depending on the breakpoint (less margin on small screens). That way, spacing would be consistent across all Angular Material apps. Refer to #1984 and #1322.

Closes #1304

@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 9, 2015
@marcysutton marcysutton added this to the 0.9.0 milestone Apr 9, 2015
@ThomasBurleson ThomasBurleson self-assigned this Apr 9, 2015
@ThomasBurleson ThomasBurleson added wip and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Apr 9, 2015
@marcysutton
Copy link
Contributor Author

@ThomasBurleson those fixes have all been included. I left layout-padding at 8px because 16px affected a bunch of things, but I do think we need a solution for other larger margins/padding units. That should be a separate discussion we have as a team.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-content: Remove md-padding class in favor of layout-padding
3 participants