This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
refactor(): change .md-padding to layout-padding #2221
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all
<md-content class="md-padding">
instances in the docs to use[layout-padding]
instead.We discussed making
md-content
padded by default given the frequency of use in our docs, but I decided against it once I saw how many things it affected.md-content
elements are frequently nested, so it undesirably stacked margins against each other.One outstanding question I have is about the default margin/padding for
md-content
: currently[layout-padding]
uses the baseline grid of8px
, but I see16px
used much more often. IMO, the framework should have one attribute that adjusts its size in SCSS depending on the breakpoint (less margin on small screens). That way, spacing would be consistent across all Angular Material apps. Refer to #1984 and #1322.Closes #1304