refactor: material-slider #255
Conversation
|
@ajoslin let me know when you're ready for an accessibility pass on the slider. |
ajoslin
force-pushed
the
wip-slider
branch
2 times, most recently
from
a1e0fe9
to
bae77ce
Compare
|
All that's left is a few unit tests. @marcysutton Ready for the pass! |
ajoslin
force-pushed
the
wip-slider
branch
2 times, most recently
from
369af74
to
f3f4c55
Compare
| * | ||
| * This should be added in a better place later. | ||
| */ | ||
| angular.element.prototype.focus = function() { |
There was a problem hiding this comment.
(function(proto) { !proto.focus && proto.focus = function() { ... }; })(angular.element.prototype);
|
Test out using ease transitions, especially for the bubble, or even try a bounce. |
|
Fix slider thumb top being clipped on focus. |
|
Doesn't support choosing from a given set of options (like a select or radio button). Pending feature: support |
| * @param {number=} max The maximum value the user is allowed to pick. Default 100. | ||
| */ | ||
| function SliderDirective() { | ||
| var hasTouch = !!('ontouchend' in document); |
There was a problem hiding this comment.
Deprecated in favor of hammerjs
ajoslin
force-pushed
the
wip-slider
branch
3 times, most recently
from
1579b50
to
88e165b
Compare
| }; | ||
| } | ||
| // Default values, overridable by attrs | ||
| attr.min ? attr.$observe('min', updateMin) : updateMin(0); |
There was a problem hiding this comment.
I'm wondering if we should just make aria-valuemin the default attribute here, so we don't have to bind and maintain multiple attributes. Sliders need aria-valuemax and aria-valuenow as well.
There was a problem hiding this comment.
Let's keep min and max as the default attributes, since that matches the native slider.
We can bind to valuemin and valuemax from the min and max, then make valuenow updated when the model is updated.
WIP of the slider. Not quite ready to merge yet.