This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(select): Ensure md-no-asterisk attribute works.
#9347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a recent change to the asterisk colors, the `md-no-asterisk` option was no longer working. - Update code to add a new `.md-no-asterisk` CSS class and fix styles. - Add appropriate tests. - Add `md-no-asterisk="false"` to demo so users can easily turn it on and test the fixed functionality. Fixes angular#9339.
topherfangio
added
ui: CSS
needs: review
| @@ -74,7 +74,8 @@ angular.module('material.components.select', [ | |||
| * @param {expression=} md-selected-text Expression to be evaluated that will return a string | |||
| * to be displayed as a placeholder in the select input box when it is closed. | |||
| * @param {string=} placeholder Placeholder hint text. | |||
| * @param md-no-asterisk {boolean=} When set to true, an asterisk will not be appended to the floating label. | |||
| * @param md-no-asterisk {boolean=} When set to true, an asterisk will not be appended to the | |||
There was a problem hiding this comment.
Why is this an opt-out? Would an opt-in not be a better approach?
There was a problem hiding this comment.
I have always pushed for the opt-in approach; however, this has been around since before 1.0 (before I joined the team I think) so I don't think we should change the API at this point.
All I did here was add a note about it only being evaluated once; not being watched.
|
This seems so inverted backwards.... wonder how I missed this one! |
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent change to the asterisk colors, the
md-no-asteriskoption was no longer working..md-no-asteriskCSS class and fix styles.md-no-asterisk="false"to demo so users can easily turn it onand test the fixed functionality.
Fixes #9339.