Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

md-select: md-no-asterisk not working #9339

Closed
binzma opened this issue Aug 18, 2016 · 2 comments · Fixed by #9347
Closed

md-select: md-no-asterisk not working #9339

binzma opened this issue Aug 18, 2016 · 2 comments · Fixed by #9347
Assignees
@topherfangio
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: bug
Milestone
1.1.1

Comments

@binzma
Copy link

binzma commented Aug 18, 2016

Actual Behavior:

  • Having an md-select with the required attribute and a placeholder attribute.
  • I would expect to disable the appended asterisk on the placeholder with the md-no-asterisk attribute. But this does not work, the asterisk is appended.

CodePen (or steps to reproduce the issue): See behavior description.

  • CodePen Demo which shows your issue:
  • Details:

Angular Versions: *

  • Angular Version: 1.5.8
  • Angular Material Version: 1.1.0

Additional Information:

  • Browser Type: Google Chrome
  • Browser Version: 52
  • OS: Windows 10
  • Stack Traces:
@Novaera
Copy link

Novaera commented Aug 18, 2016

Same case for me....

@topherfangio topherfangio added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Aug 18, 2016
@topherfangio
Copy link
Contributor

Indeed; I am working on a fix right now.

@topherfangio topherfangio added type: bug P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Aug 18, 2016
@topherfangio topherfangio added this to the 1.1.1 milestone Aug 18, 2016
topherfangio added a commit to profoundry-us/material that referenced this issue Aug 18, 2016
@topherfangio
fix(select): Ensure md-no-asterisk attribute works.
25e577f 
After a recent change to the asterisk colors, the `md-no-asterisk`
option was no longer working.

 - Update code to add a new `.md-no-asterisk` CSS class and fix styles.
 - Add appropriate tests.
 - Add `md-no-asterisk="false"` to demo so users can easily turn it on
   and test the fixed functionality.

Fixes angular#9339.
@topherfangio topherfangio mentioned this issue Aug 18, 2016
Merged
@topherfangio topherfangio added has: Pull Request A PR has been created to address this issue and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Aug 18, 2016
jelbourn pushed a commit that referenced this issue Aug 24, 2016
@topherfangio @jelbourn
fix(select): Ensure md-no-asterisk attribute works. (#9347)
f265a0e 
After a recent change to the asterisk colors, the `md-no-asterisk`
option was no longer working.

 - Update code to add a new `.md-no-asterisk` CSS class and fix styles.
 - Add appropriate tests.
 - Add `md-no-asterisk="false"` to demo so users can easily turn it on
   and test the fixed functionality.

Fixes #9339.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: bug
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

fix(select): Ensure md-no-asterisk attribute works. profoundry-us/material
3 participants
@topherfangio @Novaera @binzma