Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-nav-list disableRipple #4149

Closed
holo-michael-simarta opened this issue Apr 19, 2017 · 2 comments · Fixed by #4159
Closed

md-nav-list disableRipple #4149

holo-michael-simarta opened this issue Apr 19, 2017 · 2 comments · Fixed by #4159
Assignees
@devversion

Comments

@holo-michael-simarta
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Putting just disableRipple should disable ripples

What is the current behavior?

disableRipple="true" works

What are the steps to reproduce?

(Based on material list example)
https://plnkr.co/edit/h2Jnm62Pzbn6P0UaXtgk

What is the use-case or motivation for changing an existing behavior?

Consistency with other controls such as buttons

Which versions of Angular, Material, OS, browsers are affected?

Angular 4.0.2
Material beta.3

Is there anything else we should know?
@ocarreterom
Copy link
Contributor

disableRipple have to be set to md-list-item instead of md-nav-list.

@devversion devversion self-assigned this Apr 19, 2017
devversion added a commit to devversion/material2 that referenced this issue Apr 19, 2017
@devversion
feat(list): option to disable ripples for all items
a6b3caa 
* Allows developers to apply the `[disableRipple]` binding onto the
`md-nav-list` element.

* Removes the Provider/token stuff, since we can do more elegant by just
injecting the NavList styler.

Fixes angular#4149.
@devversion devversion mentioned this issue Apr 19, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue Apr 20, 2017
@devversion
feat(list): option to disable ripples for all items
1ddeeb5 
* Allows developers to apply the `[disableRipple]` binding onto the
`md-nav-list` element.

* Removes the Provider/token stuff, since we can do more elegant by just
injecting the NavList styler.

Fixes angular#4149.
kara pushed a commit that referenced this issue Apr 21, 2017
@devversion @kara
feat(list): option to disable ripples for all items (#4159)
7f0f473 
Fixes #4149.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(list): option to disable ripples for all items devversion/material2
3 participants
@devversion @ocarreterom @holo-michael-simarta