ng2-file-upload: false positive #284
Comments
valor-software/ng2-file-upload#1092 - the issue regarding compatibility with Angular 8 and Ivy |
@earshinov the ultimate goal of the project is to verify compatibility with Ivy. Currently, we verify partially only build-time compatibility. Would you open a PR, importing the |
@mgechev , Yes, I can do it tomorrow. |
Thanks! |
There you go: https://github.com/mgechev/ngcc-validation/pull/289
|
@earshinov is this issue still relevant? Can you reproduce it with the latest release? |
Yes, the issue is still there.
ngcc-validation already uses the latest version of ng2-file-upload npm package, 1.3.0. They are now looking for a maintainer, so I don't think we will have Ivy compatibility soon. My PR into ng2-file-upload adding support for Ivy is still open. |
This seems to have been fixed in the latest 1.4.0 release (thx @earshinov). |
Not working for latest version (1.4.0) with Angular 9. |
Hello same with Angular 9.1
|
I am going to close this issue, because the tests in this repo are passing with If it still failing for you (which based on your comments it is 😁), please open a new issue on angular/angular (where the |
Angular 9.1 I stack with this error:
|
I have just discovered this project.
Do I understand correctly that its aim is to illustrate which packages are compatible with Ivy and which are not?
If so, where can I see a list of compatible and incompatible projects?
Initially I assumed that I can just look inside the projects folder. But ng2-file-upload is there although its last release (1.3.0) is incompatible with Ivy. Here is an error message from our project:
In ng2-file-upload-ngcc,
FileUploadModule
is not even imported intoAppModule
. Perhaps that's why you did not discover this problem.The text was updated successfully, but these errors were encountered: