feta(build): update to Angular 8. Use Angular CLI instead of ngm for building. Ensure compatibility with Ivy on application side. #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aux changes: - Added package-lock.json to lock dependency versions - Removed unused @angular/http from dependencies
Some commands: npm run build - to build the library. Output is in dist/ng2-file-upload/. npm run test - to run tests. Coverage report is in coverage/ as before. npm run demo.serve - to build demo application and serve it through browsersync npm run start - to run demo application using `ng serve`. Requires the library to be built and linked first.
…he application side) Without this configuration, the following error occurs: ``` error TS-996002: Appears in the NgModule.imports of ...Module, but could not be resolved to an NgModule class ``` Configuruation taken from https://github.com/froala/angular-froala-wysiwyg/pull/329/files#diff-bb630a56aac9aa4924037d7db039769d
|
Would appreciate this being reviewed and merged. As it is right now, the project is not compatible with Ivy and will stop working in angular 9. |
45 tasks
Domainv
force-pushed
the
update-to-angular8
branch
from
1d3698a
to
18adf3f
Compare
Domainv
force-pushed
the
update-to-angular8
branch
from
bdb87cc
to
33ac156
Compare
Domainv
approved these changes
Oct 23, 2019
Domainv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1092
Some commands (copied from 7a34226):
npm run build - to build the library. Output is in dist/ng2-file-upload/.
npm run test - to run tests. Coverage report is in coverage/ as before.
npm run demo.serve - to build demo application and serve it through browsersync
npm run start - to run demo application using
ng serve. Requires the library to be built and linked first.