This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Minor clean-up and adding back failing packages #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `angular-font-awesome` project was removed from dependencies in angular#384, but `yarn.lock` was not updated to reflect that.
ChromeDriver is updated in the `postinstall` npm script. There is no need to update it again in CI, as long as we specify the correct ChromeDriver version to download in the `postinstall` script.
Previously, when a project was removed from `angular.json`, it might still remain in `passing.json`. As a result, it was difficult to identify how many projects are actually known to be passing by looking at `passing.json`. This commit adds an additional check that fails if `passing.json` contains a project that is not in `angular.json` (and thus not tested against any more).
Previously, there was list of passing projects that was used to guard against regressions. Now that more projects are passing rather than failing, it makes more sense to track failing projects instead.
gkalpak
changed the title
petebacondarwin
approved these changes
Oct 15, 2019
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clean-up and adding back a couple of failing packages that were previously removed.
See individual commit messages for details.