Remove @nguniversal/* projects
#388
Conversation
| chromeOptions: { | ||
| args: [ "--headless", "--disable-gpu"] | ||
| } | ||
| 'browserName': 'chrome' |
There was a problem hiding this comment.
These are from #385 (only the last commit is relevant for this PR).
There was a problem hiding this comment.
Can you remove @nguniversal related deps from package.json?
.circleci/config.yml
Outdated
| @@ -32,11 +32,7 @@ jobs: | |||
| - run: | |||
| name: Install Dependencies | |||
| command: | | |||
| yarn install --frozen-lockfile | |||
gkalpak
force-pushed
the
remove-nguniversal
branch
from
e6ccb44
to
f8457c0
Compare
|
@gkalpak would you rebase? |
gkalpak
force-pushed
the
remove-nguniversal
branch
from
7067227
to
ffd2fb1
Compare
|
@mgechev: Done. |
gkalpak
force-pushed
the
remove-nguniversal
branch
from
ffd2fb1
to
7887c5a
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) 鈩癸笍 Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) 鈩癸笍 Googlers: Go here for more info. |
Previously, the `@nguniversal/*` packages were imported into standard `@angular/cli` apps. However, these packages are not supposed to be used in Angular apps (on the client) and thus do not need to be processed by `ngcc`. They contain code that must be run on the server (with access to Node.js APIs) and thus the corresponding projects were failing during build, due to missing built-in Node.js modules (e.g. `fs`). We should definitely test how ngUniversal apps work with Ivy (and `ngcc`), but this is not the right way. Removing the packages for now.
gkalpak
force-pushed
the
remove-nguniversal
branch
from
a384008
to
806d424
Compare
|
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
|
FYI: Rebased on master. |
Previously, the
@nguniversal/*packages were imported into standard@angular/cliapps. However, these packages are not supposed to be used in Angular apps (on the client) and thus do not need to be processed byngcc. They contain code that must be run on the server (with access to Node.js APIs) and thus the corresponding projects were failing during build, due to missing built-in Node.js modules (e.g.fs).We should definitely test how ngUniversal apps work with Ivy (and
ngcc), but this is not the right way. Removing the packages for now.EDIT:
There are tests for ngUniversal+Ivy in the ngUniversal repo and in the
@angular/clirepo. So, we seem to be covered 馃尰This sits on top of #385. Only the last commit is new.