-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Upgrading from 2.2.0 to 2.3.0 causes "pattern did not match any files" errors #2551
Comments
It may be helpful to note that I am running protractor from Gulp using gulp-protractor |
Are you using windows? There seems to be a problem with windows since On Mon, Sep 28, 2015 at 5:35 PM, anijap notifications@github.com wrote:
|
Passing normalized string does not help. Rolling back to 2.2.0 helps. |
I managed to get around it by creating my an empty stream and then pipe gulp-protractor.
In the task where i ran gulp-protractor instead of providing a src i just start with an empty stream. SInce I have aldready provided the spec files in the config. |
Of course it would be nice to be able to use the "normal" way. But the workaround seems to work I put the specs in protractor.conf.js: Then pass an empty stream: |
that's an easier way of doing a empty stream... Don't know why I never tried that.. |
Should this be moved to |
This issue also occurs with grunt tasks. Sample output based on a grunt runner task: Some notes: the referenced file:
|
Julie, I would start by looking at The root issue may well be in a different library, but I don't have enough information at this point to be able to make that call. |
So this is conjecture, but I wonder if ff88e has something to do with this. Specifically:
Windows paths start with |
@NickTomlin I think you are on to something. This stopped working for me on Windows when upgrading to protractor 2.3.0. I logged fileName and lineNumber out during a test run. You can see the values below. var fileName = patterns[i].split(':')[0],
lineNumber = patterns[i].split(':')[1],
matches = glob.sync(fileName, { cwd: cwd });
console.log('filename: ' + fileName);
console.log('lineNumber: ' + lineNumber); filename: m
lineNumber: \path\to\my.feature
WARNING - pattern m:\workspace\path\to\my.feature did not match any files. As you can see, it's unable to find our feature files (used for cucumber.js). m is the windows drive of the current working directory. (i.e. I am sitting at |
Yup, this looks like a bug. Sorry this slipped through. |
it will be great to fix on 2.4.0. On Wed, Sep 30, 2015 at 6:25 PM, Julie Ralph notifications@github.com
|
This is fixed in 2.5.0, which is out now. |
Thanks Julie! |
With the upgrade to 2.3.0, I am unable to run my existing test suite because of these errors:
WARNING - pattern D:\code\test\foo.e2e.spec.js did not match any files.
The pattern used to find these files is:
code/tests/**/*.e2e.spec.js
Reverting back to 2.2.0 fixes these issues.
The text was updated successfully, but these errors were encountered: