Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jasmine 3.3.0 #5054

Closed
Maximaximum opened this issue Nov 23, 2018 · 15 comments
Closed

Upgrade to Jasmine 3.3.0 #5054

Maximaximum opened this issue Nov 23, 2018 · 15 comments

Comments

@Maximaximum
Copy link

Feature Request

It would be great to upgrade to Jasmine 3.3.0.

There's already an issue #4788 and a PR #4842 to upgrade to 3.1.0, but 3.3.0 has some new features including Expectation.withContext() function, which would be a very useful thing for e2e tests.

@cnishina
Copy link
Member

I will look into this. I want to use a matching version of Jasmine supported internally as well.

@cnishina cnishina added the P2 label Nov 29, 2018
cnishina added a commit to cnishina/protractor that referenced this issue Dec 10, 2018
cnishina added a commit to cnishina/protractor that referenced this issue Dec 11, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 12, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 12, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 12, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 12, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 13, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
@cnishina
Copy link
Member

Tagging this issue as kinda related: jasmine/jasmine#1522

cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
cnishina added a commit to cnishina/protractor that referenced this issue Dec 16, 2018
- version @types/jasmine 3.3 requires a minimum of typescript 2.8

closes angular#5054
@cnishina
Copy link
Member

I changed the title of the PR. I think this is the step in the right direction to getting us to 3.3

@cnishina
Copy link
Member

Could this fix #3234 ? I have no idea.... fingers crossed. I have two days and a dream to get this done.

@cnishina
Copy link
Member

Closed with #5102

@Maximaximum
Copy link
Author

Cool, thank you!
Looking forward to the new protractor release supporting Jasmine 3.3.0!

@daniell0gda
Copy link

Thanks! Do you have idea when we can use it ?

@OrangeDog
Copy link

What framework are you supposed to use with this? jasmine3 is not a valid framework.

@cnishina
Copy link
Member

cnishina commented Jun 5, 2019

This PR was to go into the selenium-webdriver 4 upgrade. This is being held back and will be released in coordination with the Angular team. Jasmine 3 I believe is a valid testing framework.

@gsai0205
Copy link

Looking forward to the new protractor release supporting Jasmine 3.3.0!

@danduh
Copy link

danduh commented Nov 17, 2019

Any updates about supporting Jasmine 3.3.0?

@manuman94
Copy link

Any updates?

@FloMaetschke
Copy link

any updates?

1 similar comment
@zhe1ka
Copy link

zhe1ka commented Jun 24, 2021

any updates?

@StanislavKharchenko
Copy link

This depends on the next release of v6-ish.
Related PR #5516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants