deps(jasmine): upgrade jasmine 3.3 #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
jk_upgrade_jasmine
branch
from
31efa51
to
e6d3939
Compare
heathkit
suggested changes
Dec 20, 2018
cnishina
force-pushed
the
jk_upgrade_jasmine
branch
from
e6d3939
to
3df59b1
Compare
|
Not working because it still relies on the previous PR to be approved. I will rebase it later. |
cnishina
force-pushed
the
jk_upgrade_jasmine
branch
from
3df59b1
to
cefc07a
Compare
|
Rebasing... |
heathkit
approved these changes
Dec 20, 2018
This was referenced Dec 20, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
|
Can someone please add some reference to why it was rolled back to 2.8 and how, if it is even possible, to work with 3.3 now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.