chore(elementArrayFinder): separate elementFinder into its own file

[hankduan]

protractor.js is growing very big. This separates ElementFinder/ElementArrayFinder (which really don't belong to the protractor class) into its own file.
Also helps with unit testing in the future by injecting a mock ptor object.

[googlebot]

CLAs look good, thanks!

[sjelin]

Is there a reason why this can't be two files - one for ElementFinder and one for ElementArrayFinder?

[hankduan]

No, it could be two files. Just figured they're so tightly bound, it's easier to put them in one file.

[sjelin]

If it would make things more complex don't bother, I was just thinking that it's easier conceptually for me to have one file per object to return.

If you're going to have one file for both, maybe a different file name though? The name elementArrayFinder.js suggests that someone might write var ElemenetArrayFinder = require('./elementArrayFinder.js'). I might try something like elementFinders.js.

[juliemr]

Let's keep it in one file (they are tightly bound) and call it element.js (matches what the test file is called, encompasses both)

[sjelin]

LGTM

[juliemr]

LGTM after file name change

[hankduan]

Closed via 015cafc

[gd46]

Hi I was wondering if someone can explain the proper method of extending ElementFinder and ElementArrayFinder, I see this issue was merged in awhile ago, but Im using protractor 2.5.1, and I have experimented with the latest protractor and I can't seem to extend either unless I use the work around described in the linked issue.

[sjelin]

Please ask support questions on Stack Overflow

[gd46]

Hi I have asked this question on StackOverflow with no luck. Can you please explain how I can override the selenium functions that are in ElementArrayFInder, WEB_ELEMENT_FUNCTIONS. I specifically looking to override the click function, but may in the future look at others.