This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(ci): Update webdriver versions in ci configs. #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'platform': 'OS X 10.9' | ||
| }, { | ||
| 'browserName': 'firefox', | ||
| 'tunnel-identifier': process.env.TRAVIS_JOB_NUMBER, | ||
| 'build': process.env.TRAVIS_BUILD_NUMBER, | ||
| 'name': 'Protractor suite tests', | ||
| 'version': '44', | ||
| 'selenium-version': '2.53.0' | ||
| 'version': '47', |
There was a problem hiding this comment.
Firefox should stay on version 44. There are issues with upgrading to 47.
|
LGTM after the tests pass. |
|
Verified, Firefox version 47 works now with the latest selenium server. |
heathkit
force-pushed
the
webdriver-update
branch
from
9300c31
to
5a6a7e6
Compare
| @@ -39,7 +39,7 @@ exports.config = { | |||
| 'tunnel-identifier': process.env.TRAVIS_JOB_NUMBER, | |||
| 'build': process.env.TRAVIS_BUILD_NUMBER, | |||
| 'name': 'Protractor smoke tests', | |||
| 'version': '9.1', | |||
| 'version': '8', | |||
| 'selenium-version': '2.53.1' | |||
There was a problem hiding this comment.
This should also be downgraded back to 2.44
- 'selenium-version': '2.44.0' // Use an old version because Safari has
- // issues loading pages after 2.44.
57c0497
to
d7bec2a
Compare
heathkit
force-pushed
the
webdriver-update
branch
from
8ee91e8
to
4bba2d0
Compare
|
It appears the tests are failing on Firefox. Let's revert back to Firefox 44. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.