Issue 3578 expected conditions #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error handler `falseIfMissing` to all expected conditions that depend on the presence of an element. Expected conditions check the presence of an element before other checks, but when an element is removed exactly in the moment after the `isPresent` and before `isDisplayed` in `visibilityOf` the condition used to fail. This solution does not handle missing elements in (`isEnable`, `isDisplayed`, `isSelected`) and focused only on expected conditions (see #3972) This problem was also referenced in #3578.
heathkit
approved these changes
Jan 27, 2017
|
Thanks so much for this! Especially for including test cases! |
|
@mgiambalvo Thanks for merging! |
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…ibility (angular#4006) Add test cases to reproduce the missing element race conditions possible in expected condition methods `visibilityOf`, `textToBePresentInElement`, `textToBePresentInValue` and `elementToBeClickable`. Add error handler `falseIfMissing` to all expected conditions that depend on the presence of an element. Expected conditions check the presence of an element before other checks, but when an element is removed exactly in the moment after the `isPresent` and before `isDisplayed` in `visibilityOf` the condition used to fail. This solution does not handle missing elements in (`isEnable`, `isDisplayed`, `isSelected`) and focused only on expected conditions (see angular#3972) This problem was also referenced in angular#3578 and angular#3777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handler
falseIfMissingto all expected conditions that dependon the presence of an element.
Expected conditions check the presence of an element before other checks,
but when an element is removed exactly in the moment after the
isPresentand before
isDisplayedinvisibilityOfthe condition used to fail.This solution does not handle missing elements in (
isEnable,isDisplayed,isSelected) and focused only on expected conditions (see#3972)
This problem was also referenced in
#3578.
Tests
Add test cases to reproduce the missing element race conditions possible in
expected condition methods
visibilityOf,textToBePresentInElement,textToBePresentInValueandelementToBeClickable.See failing tests before implementation: https://circleci.com/gh/tilmanpotthof/protractor/14