Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3578 expected conditions #4006

Merged
merged 2 commits into from
Jan 27, 2017
Merged

Issue 3578 expected conditions #4006

merged 2 commits into from
Jan 27, 2017

Commits on Jan 24, 2017

  1. fix(expectedConditions): add test cases for missing element race cond… 

    …itions

Add test cases to reproduce the missing element race conditions possible in
expected condition methods `visibilityOf`, `textToBePresentInElement`,
`textToBePresentInValue` and `elementToBeClickable`.

Issue is referenced in
#3578
#3777
    @tilmanschweitzer
    tilmanschweitzer committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    79885d1 View commit details
    Browse the repository at this point in the history

  2. fix(ExpectedConditions): handle missing element race conditions 

    Add error handler `falseIfMissing` to all expected conditions that depend
on the presence of an element.

Expected conditions check the presence of an element before other checks,
but when an element is removed exactly in the moment after the `isPresent`
and before `isDisplayed` in `visibilityOf` the condition used to fail.

This solution does not handle missing elements in (`isEnable`, `isDisplayed`, `isSelected`) and focused only on expected conditions (see
#3972)

This problem was also referenced in
#3578.
    @tilmanschweitzer
    tilmanschweitzer committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    3f29921 View commit details
    Browse the repository at this point in the history