-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs(page_objects): Remove unnecessary "return await" #4732
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@marcincharezinski agreed, maybe we can remove the async modifier as well. @joeheyming what do you think? |
@qiyigg I just pushed a commit to make getGreetingText synchronous as well. Makes sense to me. The async/await version of the code prefixes the function call with |
works for me |
Fixes #4730
More info here: https://eslint.org/docs/rules/no-return-await