Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(expectedConditions): update generic Function typings #5101

Merged
merged 1 commit into from
Dec 20, 2018
Merged

chore(expectedConditions): update generic Function typings #5101

merged 1 commit into from
Dec 20, 2018

Conversation

cnishina
Copy link
Member

@cnishina cnishina commented Dec 19, 2018 •
edited
Loading

  • Use () => Promise<boolean> over Function typings.
  • Fix an ExpectedConditions test where it was set to a const.
  • Fix a TypeScript typing interface issue with RunResults in taskRunner.

@cnishina cnishina force-pushed the upgrade_jasmine branch 5 times, most recently from 9ea9bb4 to 63ca713 Compare December 19, 2018 11:11
@cnishina
Copy link
Member Author

That worked! There was a bug in the test suite when setting the EC to a const. Since it is a global var it can be changed to a different instance. This is because the EC is tied to the browser, browsers are tied to the session. If you restart the browser or fork the browser, the const EC points to an old session.

I am not sure how this passed in previous tests. We must have made a change recently.

cnishina
cnishina commented Dec 19, 2018
View reviewed changes
Copy link
Member Author

@cnishina cnishina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add changes tomorrow...

lib/expectedConditions.ts Show resolved Hide resolved
spec/basic/expected_conditions_spec.js Outdated Show resolved Hide resolved
@cnishina
Copy link
Member Author

Backed out Jasmine 3.3 changes for ExpectedConditions and other tsc errors.

@cnishina cnishina force-pushed the upgrade_jasmine branch 2 times, most recently from 7530446 to de72230 Compare December 19, 2018 22:12
@cnishina cnishina changed the title deps(jasmine): upgrade jasmine to 3.3 chore(expectedConditions): update generic Function typings Dec 19, 2018
@cnishina cnishina mentioned this pull request Dec 19, 2018
Merged
heathkit
heathkit suggested changes Dec 20, 2018
View reviewed changes
lib/browser.ts Outdated Show resolved Hide resolved
lib/expectedConditions.ts Outdated Show resolved Hide resolved
lib/expectedConditions.ts Outdated Show resolved Hide resolved
@cnishina
chore(expectedConditions): update generic Function typings
cee662a 
- Use `() => Promise<boolean>` over `Function` typings.
- Fix an ExpectedConditions test where it was set to a const.
- Fix a TypeScript typing interface issue with RunResults in taskRunner.
@cnishina cnishina merged commit f872aa7 into angular:selenium4 Dec 20, 2018
cnishina added a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
@cnishina
chore(expectedConditions): update generic Function typings (angular#5101
68491dd 
)

- Use `() => Promise<boolean>` over `Function` typings.
- Fix an ExpectedConditions test where it was set to a const.
- Fix a TypeScript typing interface issue with RunResults in taskRunner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heathkit heathkit heathkit approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cnishina @heathkit @googlebot