Upgrade to TypeScript 3.6 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes to actual tsickle code required AFAICT (yay!). |
evmar
approved these changes
Sep 10, 2019
mprobst
force-pushed
the
ts36
branch
2 times, most recently
from
3192acf
to
749c080
Compare
Fixes #1065. The main change is to adjust goldens to changes in TS 3.6. - Iterator is now a type taking 3 template arguments. Closure and its externs have been fixed to accept 3 parameters here. - Empty constructors now get a line break, should have no impact on Closure or tsickle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.