Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark TypeScript types as non-nullable #259

Merged
merged 4 commits into from
Nov 11, 2016
Merged

Mark TypeScript types as non-nullable #259

merged 4 commits into from
Nov 11, 2016

Commits on Nov 11, 2016

  1. Enable strict null checks in the tsickle test suite. 

    All tsickle users (AFAIK) use strict null checks, and enabling these is required to properly test our nullable types conversion.
    @mprobst
    mprobst committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    412586d View commit details
    Browse the repository at this point in the history

  2. Mark TypeScript types as non-nullable. 

    All TypeScript types in strictNullChecks mode are non-nullable, where Closure types without a ! are treated as nullable. This change adds ! on all types except for types treated as never null primitives by Closure Compiler (number, string, function).
    @mprobst
    mprobst committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    ed55add View commit details
    Browse the repository at this point in the history

  3. Support translating foo! expressions into type asserts.

    @mprobst
    mprobst committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    427ab3f View commit details
    Browse the repository at this point in the history

  4. Remove the special case for optional members. These types are covered… 

    … by TypeScript including |undefined in a union type in strictNullChecks mode.
    @mprobst
    mprobst committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    fbad0fd View commit details
    Browse the repository at this point in the history