Mark TypeScript types as non-nullable #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @dpurp |
All tsickle users (AFAIK) use strict null checks, and enabling these is required to properly test our nullable types conversion.
All TypeScript types in strictNullChecks mode are non-nullable, where Closure types without a ! are treated as nullable. This change adds ! on all types except for types treated as never null primitives by Closure Compiler (number, string, function).
mprobst
force-pushed
the
simpler-null
branch
from
02a2d1b
to
427ab3f
Compare
vikerman
reviewed
Nov 11, 2016
|
|
||
| let /** @type {(string|boolean)} */ typeUnion: string|boolean = Math.random() > 0.5 ? false : ''; | ||
| let /** @type {(string|boolean)} */ typeUnion2: (string|boolean) = Math.random() > 0.5 ? false : ''; | ||
| let /** @type {{optional: (boolean|undefined)}} */ typeOptionalField: {optional?: boolean} = {}; | ||
| let /** @type {{optional: ((string|boolean)|undefined)}} */ typeOptionalUnion: {optional?: string|boolean} = {}; | ||
| let /** @type {{optional: ((undefined|boolean)|undefined)}} */ typeOptionalField: {optional?: boolean} = {}; |
There was a problem hiding this comment.
Is there a way to collapse the two undefined?
There was a problem hiding this comment.
Good point, done (and simplifies the code!).
… by TypeScript including |undefined in a union type in strictNullChecks mode.
vikerman
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required some more yaks to loose their fur.
Note that the support for NonNullable expressions is very flakey, due to microsoft/TypeScript#9873, just as it was for casts before.