Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof of concept: typescript transformer support for tsickle #507

Closed
wants to merge 1 commit into from
Closed

Proof of concept: typescript transformer support for tsickle #507

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented May 31, 2017 •
edited
Loading

Needs:

  • review of general direction
  • test in G3
  • add tests for source maps with transformers
  • split into multiple meaningful commits for the review

@tbosch tbosch force-pushed the transform branch 2 times, most recently from 802eb2f to 5aa6990 Compare May 31, 2017 22:24
@mprobst
Copy link
Contributor

mprobst commented Jun 1, 2017 •
edited
Loading

Thanks for the change! This is very interesting.

I'm not quite sure how to make progress on this though – as is, this is just a huge lump of code (and overall in not quite reviewable state, AFAICT). Could you maybe write up a doc explaining the basic approach, and giving a guided tour through the changes? We could also have a meeting and walk through the code.

Whoops, just saw that you did just this. I'll follow up :-)

@mprobst mprobst self-requested a review June 1, 2017 08:58
@orenmizr
Copy link

orenmizr commented Jun 7, 2017

Hi, i'm just watching progress on this project. what is change (typescript transformer) about ? #curious

@evmar
Copy link
Contributor

evmar commented Jun 7, 2017 via email

@tbosch tbosch force-pushed the transform branch 2 times, most recently from e14a92a to 0326c50 Compare June 13, 2017 16:24
tbosch
tbosch commented Jun 13, 2017
View reviewed changes
src/rewriter.ts
source: this.file.fileName,
});
if (text.indexOf('A Used by implement_import.ts') !== -1) {
console.log('>>> now', node.kind, new Error().stack);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@tbosch
Copy link
Contributor Author

tbosch commented Jun 13, 2017

Prefactor PR is here: #514

@tbosch
Copy link
Contributor Author

tbosch commented Jun 14, 2017

Final PR is here: #516

@tbosch tbosch closed this Jun 14, 2017
@tbosch tbosch deleted the transform branch July 31, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprobst mprobst Awaiting requested review from mprobst

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbosch @mprobst @orenmizr @evmar @googlebot