Update source-map dependency. #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprobst
approved these changes
Feb 19, 2018
| * This interface was defined in @types/source-map but is absent from the typings | ||
| * distributed in the source-map package. | ||
| * Copied from https://unpkg.com/@types/source-map@0.5.2/index.d.ts | ||
| * see https://github.com/angular/tsickle/issues/750 |
There was a problem hiding this comment.
leave a TODO with instructions on how to fix eventually?
There was a problem hiding this comment.
I don't think there's any action to take, probably not worth making a fix upstream for their typings? Maybe they prefer these APIs be undocumented. I'll open an issue at least...
There was a problem hiding this comment.
Ah, I'm wrong, mozilla/source-map@7c06ac8#diff-7945f6bb445d956794564e098ef20bb3 adds the toJSON method among other things.
However that's only in the 0.7 release which adds more breaking changes, eg. the SourceMapConsumer constructor is now a sync (???)
So I think we should land this, I'll update the comments.
alexeagle
force-pushed
the
source-map
branch
2 times, most recently
from
4672557
to
ab40524
Compare
This is needed to pick up the fix for mozilla/source-map#273 Closes angular#750
alexeagle
force-pushed
the
source-map
branch
from
ab40524
to
74b5dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to pick up the fix for mozilla/source-map#273
Closes #750