"typings" field in package.json is broken

[alexeagle]

the typings field was added by
6f5d594
which also added source-map.d.ts, however that file wasn't included in the published package:
https://unpkg.com/source-map@0.5.7/

foo.ts(1,21): error TS7016: Could not find a declaration file for module 'source-map'. '/usr/local/google/home/alexeagle/Projects/repro_source-map/node_modules/source-map/source-map.js' implicitly has an 'any' type.
  Try `npm install @types/source-map` if it exists or add a new declaration (.d.ts) file containing `declare module 'source-map';`

/cc @tbosch

[tromey]

Is it sufficient to add source-map.d.ts to the files array in package.json?

[tromey]

If I npm install source-map, what's installed includes everything from files, so I think it's fine to just list it.

[alexeagle]

It doesn't matter what npm install does if the file isn't published to NPM

[tromey]

I don't understand. The idea of the patch is that the things in files are published, so (1) fix up the file list, and then (2) publish to npm. https://docs.npmjs.com/files/package.json claims that this should be sufficient. Or is there some other scenario that's important that I don't know of?

[alexeagle]

Yes, that sounds right. I'm not familiar with the publishing steps here - in some of our repos we run npm publish from the dist folder so that would be broken. Also there could be .npmignore to control what is published, but don't have one here. The real test is to run npm publish in dry-run mode, which seems to be npm pack

[tromey]

Thanks for mentioning npm pack. I confirmed that this works.