-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hapi-engine): update hapi-engine integration #599
Conversation
@bisubus Let us know if you need any help with how the express engine is doing things. Shouldn't be too bad though. Also, thanks for working on the integration, keep it up! 👍 |
@MarkPieszak Thanks, I guess I've sorted this out, rendering part is quite straightforward. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
That's ok, googlebot. |
Need this! 👍 |
@todo: remove src/app/hapi-engine.ts when angular/universal#599 is merged
won't be added in ng4 |
@todo: remove src/app/hapi-engine.ts when angular/universal#599 is merged
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
remove unused proxy imports from some test files
Adds the implementation of Hapi template view engine for Universal, similar to Express engine.
No