Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hapi-engine): update hapi-engine integration #599

Closed
wants to merge 4 commits into from

Conversation

bisubus
Copy link

@bisubus bisubus commented Oct 18, 2016

  • What modules are related to this pull-request
  • express-engine
  • grunt-prerender
  • gulp-prerender
  • hapi-engine
  • universal-next
  • universal
  • webpack-prerender
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove unused proxy imports from some test files

Adds the implementation of Hapi template view engine for Universal, similar to Express engine.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

@MarkPieszak
Copy link
Member

MarkPieszak commented Oct 18, 2016

@bisubus Let us know if you need any help with how the express engine is doing things. Shouldn't be too bad though.

Also, thanks for working on the integration, keep it up! 👍

@bisubus
Copy link
Author

bisubus commented Oct 18, 2016

@MarkPieszak Thanks, I guess I've sorted this out, rendering part is quite straightforward.

@MarkPieszak MarkPieszak changed the title Add new Hapi engine implementation fix(Hali-engine): fix hapi-engine integration Oct 20, 2016
@MarkPieszak MarkPieszak changed the title fix(Hali-engine): fix hapi-engine integration fix(hapi-engine): fix hapi-engine integration Oct 20, 2016
@MarkPieszak MarkPieszak changed the title fix(hapi-engine): fix hapi-engine integration fix(hapi-engine): update hapi-engine integration Oct 20, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@bisubus
Copy link
Author

bisubus commented Nov 1, 2016

That's ok, googlebot.

@yannickglt
Copy link

Need this! 👍

yannickglt pushed a commit to Boulangerie/angular2-universal-hapi that referenced this pull request Dec 16, 2016
@PatrickJS
Copy link
Member

won't be added in ng4
angular/angular#13822

@PatrickJS PatrickJS closed this Jan 8, 2017
yannickglt pushed a commit to Boulangerie/angular2-universal-hapiour that referenced this pull request Feb 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants