Component type is lost due to input binding with expression #1278
Comments
atscott
added
the
lib
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 13, 2021
… matching The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. When an attibute has a complex (non-literal primitive) value, this code would previously generate an invalid attribute such as `[attrName='1' + '2']`. For cases where the attribute is bound to an expression that is not a literal primitive, this commit changes the logic to only generate the attribute name and exclude the value. Fixes angular/vscode-ng-language-service#1278
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 13, 2021
… matching The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. When an attibute has a complex (non-literal primitive) value, this code would previously generate an invalid attribute such as `[attrName='1' + '2']`. For cases where the attribute is bound to an expression that is not a literal primitive, this commit changes the logic to only generate the attribute name and exclude the value. Fixes angular/vscode-ng-language-service#1278
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 13, 2021
… matching The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. When an attibute has a complex (non-literal primitive) value, this code would previously generate an invalid attribute such as `[attrName='1' + '2']`. For cases where the attribute is bound to an expression that is not a literal primitive, this commit changes the logic to only generate the attribute name and exclude the value. Fixes angular/vscode-ng-language-service#1278
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 13, 2021
…tching The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. The compiler itself does a similar thing. In addition, the compiler does not use the value of `BoundAttribute`s to match directives (https://github.com/angular/angular/blob/cdf1ea1951fb7187b1f6c9bb8a847c859c41e0b8/packages/compiler/src/render3/view/util.ts#L174-L206). This commit changes the language service to also ignore bound attribute values for directive matching. Fixes angular/vscode-ng-language-service#1278
zarend
pushed a commit
to angular/angular
that referenced
this issue
Apr 14, 2021
…tching (#41597) The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. The compiler itself does a similar thing. In addition, the compiler does not use the value of `BoundAttribute`s to match directives (https://github.com/angular/angular/blob/cdf1ea1951fb7187b1f6c9bb8a847c859c41e0b8/packages/compiler/src/render3/view/util.ts#L174-L206). This commit changes the language service to also ignore bound attribute values for directive matching. Fixes angular/vscode-ng-language-service#1278 PR Close #41597
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When you add an input binding with an expression the component is then of type
HTMLElementinstead ofFooComponent.Additional context
Angular Language Server: 11.2.10
Angular CLI: 12.0.0-next.8
Node: 12.18.0
OS: darwin x64
Angular: 12.0.0-next.8
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Package Version
@angular-devkit/architect 0.1200.0-next.8
@angular-devkit/build-angular 0.1200.0-next.8
@angular-devkit/core 12.0.0-next.8
@angular-devkit/schematics 12.0.0-next.8
@angular/cdk 12.0.0-next.6
@angular/fire 6.1.4
@angular/material 12.0.0-next.6
@nguniversal/builders 12.0.0-next.1
@nguniversal/express-engine 12.0.0-next.1
@schematics/angular 12.0.0-next.8
rxjs 6.6.6
typescript 4.2.3
The text was updated successfully, but these errors were encountered: