Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: code folding support for block syntax #1930

Closed
1 of 2 tasks
eneajaho opened this issue Oct 4, 2023 · 2 comments
Closed
1 of 2 tasks

feat: code folding support for block syntax #1930

eneajaho opened this issue Oct 4, 2023 · 2 comments
Labels
feature

Comments

@eneajaho
Copy link

eneajaho commented Oct 4, 2023

🚀 feature request

Feature Type

What does this bug affect

  • Angular Language Service VSCode extension
  • Angular Language Service server

Describe the solution you'd like

If you have a solution in mind, please describe it.

I want to be able to fold blocks in the new template syntax
CleanShot 2023-10-04 at 11 26 38@2x
atscott added a commit to atscott/angular that referenced this issue Oct 5, 2023
@atscott
feat(language-service): Implement outlining spans for control flow bl…
2fd64c8 
…ocks

This commit implements the getOutlingSpans to retrieve Angular-specific
outlining spans. At the moment, these spans are limited to control-flow
blocks in templates.

This is required for folding ranges (angular/vscode-ng-language-service#1930)
atscott added a commit to atscott/angular that referenced this issue Oct 5, 2023
@atscott
feat(language-service): Implement outlining spans for control flow bl…
afb04fd 
…ocks

This commit implements the getOutlingSpans to retrieve Angular-specific
outlining spans. At the moment, these spans are limited to control-flow
blocks in templates.

This is required for folding ranges (angular/vscode-ng-language-service#1930)
atscott added a commit to atscott/angular that referenced this issue Oct 5, 2023
@atscott
feat(language-service): Implement outlining spans for control flow bl…
2531fff 
…ocks

This commit implements the getOutlingSpans to retrieve Angular-specific
outlining spans. At the moment, these spans are limited to control-flow
blocks in templates.

This is required for folding ranges (angular/vscode-ng-language-service#1930)
@atscott atscott mentioned this issue Oct 5, 2023
Closed
atscott added a commit to angular/angular that referenced this issue Oct 9, 2023
@atscott
feat(language-service): Implement outlining spans for control flow bl…
023a181 
…ocks (#52062)

This commit implements the getOutlingSpans to retrieve Angular-specific
outlining spans. At the moment, these spans are limited to control-flow
blocks in templates.

This is required for folding ranges (angular/vscode-ng-language-service#1930)

PR Close #52062
@atscott
Copy link
Collaborator

atscott commented Oct 11, 2023

Fixed by #1938

@atscott atscott closed this as completed Oct 11, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atscott @eneajaho