Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick info stops working if there are two components in the same file and I change a field in parent component #2064

Closed
2 tasks done
eneajaho opened this issue Jul 11, 2024 · 0 comments · Fixed by #2067
Closed
2 tasks done

quick info stops working if there are two components in the same file and I change a field in parent component #2064

eneajaho opened this issue Jul 11, 2024 · 0 comments · Fixed by #2067
Labels
bug

Comments

@eneajaho
Copy link

🐞 bug report

Description

CleanShot.2024-07-11.at.11.33.01.mp4

Bug Type

What does this bug affect

  • Angular Language Service VSCode extension
  • Angular Language Service server

Expected behavior

Quick info to not stop working
@eneajaho eneajaho added the bug label Jul 11, 2024
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 16, 2024
@atscott
fix(extension): Allow requests to reach the language server when in c…
30eaaa8 
…omponent decorator

This commit updates the early-return logic on the client-side to allow
requests to go to the server whenever the cursor is inside the component
decorator. Prior to this change, some requests would attempt to return
early if the position was not inside the inline template region.
However, we were never able to get the tokenizing working correctly and
this has led to issues whenever there are multiple template strings
(JS template strings with \`).

This approach should give us the needed benefits of early-returns in
non-Angular contexts (@component decorator should be pretty rare) while
being more permissive and correct.

fixes angular#2064
@atscott atscott mentioned this issue Jul 16, 2024
Merged
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 16, 2024
@atscott
fix(extension): Allow requests to reach the language server when in c…
5e6fdb8 
…omponent decorator

This commit updates the early-return logic on the client-side to allow
requests to go to the server whenever the cursor is inside the component
decorator. Prior to this change, some requests would attempt to return
early if the position was not inside the inline template region.
However, we were never able to get the tokenizing working correctly and
this has led to issues whenever there are multiple template strings
(JS template strings with \`).

This approach should give us the needed benefits of early-returns in
non-Angular contexts (`@Component` decorator should be pretty rare) while
being more permissive and correct.

fixes angular#2064
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 17, 2024
@atscott
fix(extension): Allow requests to reach the language server when in c…
36a21f0 
…omponent decorator

This commit updates the early-return logic on the client-side to allow
requests to go to the server whenever the cursor is inside the component
decorator. Prior to this change, some requests would attempt to return
early if the position was not inside the inline template region.
However, we were never able to get the tokenizing working correctly and
this has led to issues whenever there are multiple template strings
(JS template strings with \`).

This approach should give us the needed benefits of early-returns in
non-Angular contexts (`@Component` decorator should be pretty rare) while
being more permissive and correct.

fixes angular#2064
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 17, 2024
@atscott
fix(extension): Allow requests to reach the language server when in c…
7287984 
…omponent decorator

This commit updates the early-return logic on the client-side to allow
requests to go to the server whenever the cursor is inside the component
decorator. Prior to this change, some requests would attempt to return
early if the position was not inside the inline template region.
However, we were never able to get the tokenizing working correctly and
this has led to issues whenever there are multiple template strings
(JS template strings with \`).

This approach should give us the needed benefits of early-returns in
non-Angular contexts (`@Component` decorator should be pretty rare) while
being more permissive and correct.

fixes angular#2064
atscott added a commit that referenced this issue Jul 19, 2024
@atscott
fix(extension): Allow requests to reach the language server when in c…
5618fce 
…omponent decorator (#2067)

This commit updates the early-return logic on the client-side to allow
requests to go to the server whenever the cursor is inside the component
decorator. Prior to this change, some requests would attempt to return
early if the position was not inside the inline template region.
However, we were never able to get the tokenizing working correctly and
this has led to issues whenever there are multiple template strings
(JS template strings with \`).

This approach should give us the needed benefits of early-returns in
non-Angular contexts (`@Component` decorator should be pretty rare) while
being more permissive and correct.

fixes #2064

(cherry picked from commit 48a800f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@eneajaho