Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this extension #298

Closed
cyrilletuzi opened this issue Nov 13, 2018 · 7 comments
Closed

Status of this extension #298

cyrilletuzi opened this issue Nov 13, 2018 · 7 comments

Comments

@cyrilletuzi
Copy link

cyrilletuzi commented Nov 13, 2018

@kyliau @StephenFluin I would like to know the status of this extension, as it doesn't seem actively maintained anymore, while it's a major VS Code extension to have a good Angular development experience.

As an Angular trainer, I teach courses in many different companies with different hardwares (from very good to very bad), so here is some feedback.

Previously:

  • the extension was (quite) reliable on computers with good hardware,
  • but it was really messy on computers with bad hardware.

It is mainly because of the process checking if components are declared: as the CLI creates files on the fly, the extension has to refresh the whole project to know a new component is indeed declared in a NgModule. But it can take a really long time when the hardware is bad, and often it even doesn't work at all until a full restart of VS Code.

Restart of VS Code = you also need to launch ng serve again, which is also very slow on bad hardware, resulting in a very bad overall dev experience. For beginners, it's really bad: each time they create a new component, the extension reports errors which are not really errors, and students are completely confused.

But from a few weeks, the extension is now also unreliable on computers with good hardware. I suppose it's because the extension has not been updated for Angular 7 and TypeScript 3.1.

The course I'm teaching this week has been really disturbed by these issues.

Also, compared to React JSX, this extension was the answer for Angular to have (quite) the same level of assistance and validation. So it's very important, and if it's not maintained anymore, it would be a huge step back.

@kyliau
Copy link
Contributor

kyliau commented Nov 13, 2018

@cyrilletuzi thank you for the feedback.
The extension was originally authored by @chuckjaz. Since Chuck moved on to another team, the development of this work has been deprioritized.
We do have plans to release a new version, but it's currently pending the release of Ivy. That's because with Ivy, there'll be a significant change (namely metadata.json will no longer be generated) that would fundamentally change how the language service works. For the next version, we'll also convert the tool to be a Typescript plugin, as you mentioned.
Meanwhile, I'll take a look at upgrading the current implementation to support Angular 7 and Typescript 3.1

@dylanvdmerwe
Copy link

Ivy is only coming around Angular 8 time frame. There are many maintenance issues that still should be addressed in the mean time - this is a major plugin for many angular developers in a very popular cross platform editor and it being deprioritized is really not great news.

@cyrilletuzi
Copy link
Author

cyrilletuzi commented Nov 15, 2018

@kyliau Thanks for the answser.

@dylanvdmerwe I've got an idea, I'll release it very soon and post an update here.

@cyrilletuzi
Copy link
Author

For everyone who wants an efficient and up to date Angular Language Service in VS Code:
https://marketplace.visualstudio.com/items?itemName=cyrilletuzi.typescript-angular-plugin 👍

@denspiro
Copy link

@cyrilletuzi Installed. Will give it a battle test immediately.

@cyrilletuzi
Copy link
Author

Closing this as the extension has been updated.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants