Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Ivy LS the default #1279

Merged
merged 1 commit into from Apr 12, 2021
Merged

fix: make Ivy LS the default #1279

merged 1 commit into from Apr 12, 2021

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 12, 2021

Ivy LS will be the default in Angular v12.

To revert to legacy View Engine LS, enable the view-engine option:

Screen Shot 2021-04-12 at 2 12 26 PM

@kyliau kyliau requested a review from atscott April 12, 2021 21:14
@google-cla google-cla bot added the cla: yes label Apr 12, 2021
atscott
atscott approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending rebase)

@atscott atscott added cleanup Cleanup needed before PR could be merged target: major This PR is targeted for the next major release labels Apr 12, 2021
@kyliau
fix: make Ivy LS the default
d1e9db8 
Ivy LS will be the default in Angular v12.
@kyliau kyliau merged commit c23612f into angular:master Apr 12, 2021
@kyliau kyliau deleted the ivy-default branch April 12, 2021 22:27
@kapunahelewong kapunahelewong mentioned this pull request Apr 13, 2021
Closed
@kyliau kyliau removed the cleanup Cleanup needed before PR could be merged label Apr 13, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyliau @atscott